fix(ui): install chat modules from released archives#48
Open
vernonstinebaker wants to merge 1 commit intonullclaw:mainfrom
Open
fix(ui): install chat modules from released archives#48vernonstinebaker wants to merge 1 commit intonullclaw:mainfrom
vernonstinebaker wants to merge 1 commit intonullclaw:mainfrom
Conversation
NullHub expected a bundle filename and flat archive layout that current nullclaw-chat-ui releases do not provide, which left chat modules installed but unloadable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*-bundle.tar.gznullclaw-chat-ui-<tag>.tar.gzarchive naming used bynullclaw-chat-uireleasesmodule.jsWhy
NullHub's chat tab dynamically imports
/ui/<module>@<version>/module.js. Recentnullclaw-chat-uireleases published archives containing a top-level package directory and no*-bundle.tar.gzasset, so NullHub could install a module directory but still fail to serve the embeddable entrypoint where the UI expected it. That left the chat tab stuck onFailed to load module: Importing a module script failed.Validation
zig build test -Dbuild-ui=false -Dembed-ui=false --summary allGET /api/ui-modulesGET /ui/nullclaw-chat-ui@latest/module.js->200 OKdefaultandwilly-nillyload once the fixed chat-ui release layout is installedNotes
nullclaw-chat-uirelease packaging fix is submitted separately